Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow multiple listener rule condition blocks #359

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat: Allow multiple listener rule condition blocks #359

merged 2 commits into from
Mar 8, 2024

Conversation

trevorrea
Copy link
Contributor

Description

This change allow multiple condition blocks to be defined in a listener rule

Motivation and Context

Resolves #347

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects - planned but not applied due to not having a sandbox AWS account available
  • I have executed pre-commit run -a on my pull request

@trevorrea trevorrea changed the title Change condition blocks to allow multiple blocks in the same way as action blocks fix: Change condition blocks to allow multiple blocks in the same way as action blocks Mar 7, 2024
Copy link

@alexgoddity alexgoddity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thanks

@bryantbiggs
Copy link
Member

This is on my list for tomorrow

@bryantbiggs bryantbiggs changed the title fix: Change condition blocks to allow multiple blocks in the same way as action blocks feat: Allow multiple listener rule condition blocks Mar 8, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 8132110 into terraform-aws-modules:master Mar 8, 2024
10 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 8, 2024
## [9.8.0](v9.7.1...v9.8.0) (2024-03-08)

### Features

* Allow multiple listener rule condition blocks ([#359](#359)) ([8132110](8132110))
@antonbabenko
Copy link
Member

This PR is included in version 9.8.0 🎉

Copy link

github-actions bot commented Apr 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to create alb listeners rule with multiple conditions
4 participants